fix(core-forger): update configManager height #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2487 +/- ##
=========================================
+ Coverage 66.09% 66.1% +<.01%
=========================================
Files 400 400
Lines 8610 8611 +1
Branches 394 435 +41
=========================================
+ Hits 5691 5692 +1
+ Misses 2875 2874 -1
- Partials 44 45 +1
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Apr 26, 2019
vasild
added a commit
that referenced
this pull request
Apr 26, 2019
…tion-expiration-in-height * ArkEcosystem/core/develop: fix(core): parse only the last line of pm2 stdout (#2484) release: 2.3.18 (#2488) fix(core-snapshots): reset unfinished round after import (#2486) fix(core-forger): update configManager height (#2487) release: 2.3.16 (#2483) fix(core-database): initialize height on startup (#2482)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to ensure the configManager is always on the same height as the block that is about to be forged. Otherwise the forger can run into trouble when milestones alter the transaction validation. Currently this is only guaranteed when forger and relay run in the same process.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
Checklist