Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-tester-cli): pass the base flags for programmatic calls #2108

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Resolves #2094

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@ghost
Copy link

ghost commented Feb 17, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 17, 2019 05:36
@ghost
Copy link

ghost commented Feb 17, 2019

@faustbrian The ci/circleci: test-node11-2 job is failing as of 626bf36525d9c86988713234d948f17cb7013485. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #2108 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2108   +/-   ##
========================================
  Coverage    78.92%   78.92%           
========================================
  Files          330      330           
  Lines         7973     7973           
  Branches      1116     1114    -2     
========================================
  Hits          6293     6293           
  Misses        1648     1648           
  Partials        32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f03f7...8a07b8f. Read the comment docs.

@faustbrian faustbrian changed the title fix(core-tester-cli): pass the base arguments during programmatic calls fix(core-tester-cli): pass the base flags for programmatic calls Feb 17, 2019
@faustbrian faustbrian merged commit 6c847f7 into develop Feb 18, 2019
@ghost ghost deleted the fix/tester-cli-flags branch February 18, 2019 03:50
@ghost ghost removed the Status: Needs Review label Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants