Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-api): add sorting to voters endpoint #2103

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Feb 15, 2019

Proposed changes

Adds support for ordering to the delegates/{id}/voters endpoint and returns the voters ordered by balance:desc by default.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost
Copy link

ghost commented Feb 15, 2019

@dated Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ghost
Copy link

ghost commented Feb 15, 2019

@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Feb 16, 2019

@dated A collaborator has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@faustbrian faustbrian merged commit 7b9fe68 into ArkEcosystem:develop Feb 16, 2019
@ghost
Copy link

ghost commented Feb 16, 2019

@dated Your pull request has been merged but was not assigned a bounty tier. @air1one @faustbrian @supaiku0 - please assign a bounty tier to this pull request in the next few days.

@ghost
Copy link

ghost commented Feb 16, 2019

@dated Your pull request has been merged and marked as tier 2. It will earn you $50 USD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants