refactor: move genesisBlock to network config and remove extraneous config #2052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@supaiku0 @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
@faustbrian The ci/circleci: test-node10-2 job is failing as of 0dff5a7a2136853a87f14fa3dbb82836aa08d4db. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #2052 +/- ##
===========================================
+ Coverage 73.8% 73.81% +<.01%
===========================================
Files 367 367
Lines 8258 8259 +1
Branches 1188 1165 -23
===========================================
+ Hits 6095 6096 +1
Misses 2131 2131
Partials 32 32
Continue to review full report at Codecov.
|
spkjp
approved these changes
Feb 2, 2019
ghost
deleted the
ghost
mentioned this pull request
vasild
added a commit
that referenced
this pull request
Feb 4, 2019
…peer-state * ArkEcosystem/core/develop: chore: few upgrade script fixes (#2060) misc: add github templates for docs, security and support (#2059) fix: remove entries with double and single quotes during the upgrade fix: syntax error in upgrade script fix(crypto): disable multisig (#2057) chore: add bash fallback for ARK > CORE in upgrade script refactor: move genesisBlock to network config and remove extraneous config (#2052) chore: store development docker files in docker/development (#2053)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Right now the genesis block is exposed to the user and stored in the config directory. This shouldn't be the case as the genesisBlock is specific to a network, not a user.
Types of changes
Checklist