-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core-p2p): ip address validation #2045
Conversation
@faustbrian @alexbarnsley - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## develop #2045 +/- ##
===========================================
+ Coverage 73.26% 73.31% +0.04%
===========================================
Files 373 373
Lines 8222 8243 +21
Branches 1196 1212 +16
===========================================
+ Hits 6024 6043 +19
Misses 2165 2165
- Partials 33 35 +2
Continue to review full report at Codecov.
|
Proposed changes
This PR adds the ip address fix from #2042 and simplifies the checks we do by moving some stuff into a new helper.
Types of changes
Checklist