Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): ip address validation #2045

Merged
merged 7 commits into from
Jan 31, 2019
Merged

fix(core-p2p): ip address validation #2045

merged 7 commits into from
Jan 31, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Jan 31, 2019

Proposed changes

This PR adds the ip address fix from #2042 and simplifies the checks we do by moving some stuff into a new helper.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian January 31, 2019 17:04
@ghost
Copy link

ghost commented Jan 31, 2019

@faustbrian @alexbarnsley - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #2045 into develop will increase coverage by 0.04%.
The diff coverage is 92.1%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2045      +/-   ##
===========================================
+ Coverage    73.26%   73.31%   +0.04%     
===========================================
  Files          373      373              
  Lines         8222     8243      +21     
  Branches      1196     1212      +16     
===========================================
+ Hits          6024     6043      +19     
  Misses        2165     2165              
- Partials        33       35       +2
Impacted Files Coverage Δ
packages/core-p2p/src/court/guard.ts 79.59% <ø> (-0.41%) ⬇️
packages/core-p2p/src/peer.ts 88.88% <ø> (-0.13%) ⬇️
packages/core-p2p/src/monitor.ts 53.77% <83.33%> (+0.24%) ⬆️
packages/core-p2p/src/utils/is-valid-peer.ts 96.15% <96.15%> (ø)
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10a948...ad03c70. Read the comment docs.

@faustbrian faustbrian merged commit fd1bb45 into ArkEcosystem:develop Jan 31, 2019
@ghost ghost removed the Status: Needs Review label Jan 31, 2019
vasild added a commit that referenced this pull request Jan 31, 2019
…peer-state

* ArkEcosystem/core/develop:
  fix(core-p2p): ip address validation (#2045)
  refactor: remove progress tracker and further reduce log noise (#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants