Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove progress tracker and further reduce log noise #2044

Merged
merged 3 commits into from
Jan 31, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Reduce the log noise and remove the atrocious progress bars that make the log unreadable during start up.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian requested a review from spkjp January 31, 2019 15:24
@ghost
Copy link

ghost commented Jan 31, 2019

@alexbarnsley @supaiku0 - please review this pull request in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #2044 into develop will decrease coverage by 0.02%.
The diff coverage is 26.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2044      +/-   ##
===========================================
- Coverage    73.29%   73.27%   -0.03%     
===========================================
  Files          373      373              
  Lines         8256     8223      -33     
  Branches      1213     1207       -6     
===========================================
- Hits          6051     6025      -26     
+ Misses        2171     2163       -8     
- Partials        34       35       +1
Impacted Files Coverage Δ
packages/core-logger/src/logger.ts 100% <ø> (ø) ⬆️
packages/core-p2p/src/monitor.ts 53.52% <ø> (+0.36%) ⬆️
packages/core-database-postgres/src/spv.ts 7.4% <0%> (+0.06%) ⬆️
packages/core-logger-winston/src/formatter.ts 43.75% <0%> (+4.86%) ⬆️
...ges/core-blockchain/src/utils/tick-sync-tracker.ts 23.8% <0%> (+1.08%) ⬆️
packages/core-logger-winston/src/driver.ts 93.1% <100%> (-3.2%) ⬇️
packages/core-blockchain/src/blockchain.ts 80.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c922325...059d80a. Read the comment docs.

@spkjp spkjp merged commit b10a948 into develop Jan 31, 2019
@ghost ghost deleted the refactor/log-noise branch January 31, 2019 18:23
@ghost ghost removed the Status: Needs Review label Jan 31, 2019
vasild added a commit that referenced this pull request Jan 31, 2019
…peer-state

* ArkEcosystem/core/develop:
  fix(core-p2p): ip address validation (#2045)
  refactor: remove progress tracker and further reduce log noise (#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants