Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): remove validation rules and validator #2021

Merged
merged 4 commits into from
Jan 28, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

A bunch of old and unused code was left over from constant changes and refactoring of the crypto validation parts. I removed the Validator class as I couldn't find any place where it was used as we always use the Joi alias we export which is an instance of the Engine class.

Resolves #2015
Resolves #2020

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

codecov-io commented Jan 27, 2019

Codecov Report

Merging #2021 into develop will decrease coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2021      +/-   ##
===========================================
- Coverage     73.1%   72.69%   -0.41%     
===========================================
  Files          386      373      -13     
  Lines         8351     8252      -99     
  Branches      1193     1195       +2     
===========================================
- Hits          6105     5999     -106     
- Misses        2213     2218       +5     
- Partials        33       35       +2
Impacted Files Coverage Δ
...pto/src/validation/extensions/transactions/base.ts 100% <ø> (ø) ⬆️
...es/crypto/src/validation/validators/transaction.ts 100% <100%> (ø) ⬆️
...ages/crypto/src/validation/extensions/bignumber.ts 100% <100%> (ø) ⬆️
packages/crypto/src/validation/validator.ts 100% <100%> (ø) ⬆️
.../crypto/src/handlers/transactions/multi-payment.ts 30% <0%> (-70%) ⬇️
packages/core-test-utils/src/helpers/container.ts 0% <0%> (ø) ⬆️
packages/core-test-utils/src/generators/wallets.ts 14.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eea3a76...81590f6. Read the comment docs.

@spkjp spkjp merged commit 4b59073 into develop Jan 28, 2019
@spkjp spkjp deleted the refactor/crypto-validator branch January 28, 2019 12:05
vasild added a commit that referenced this pull request Jan 29, 2019
* develop:
  test(core-transaction-pool): 100% coverage (#2030)
  chore: fix exit in install script (#2025)
  chore: add centOS support to install script and some fixes (#2024)
  refactor(crypto): remove validation rules and validator (#2021)
  fix(crypto): add missing devnet block exceptions (#2023)
@spkjp spkjp mentioned this pull request Jan 31, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants