Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): export type definitions #1917

Merged
merged 3 commits into from
Dec 30, 2018
Merged

refactor(crypto): export type definitions #1917

merged 3 commits into from
Dec 30, 2018

Conversation

paroxysm
Copy link
Contributor

Proposed changes

Resolves #1792

This PR simply exposes the types in crypto, but it doesn't propagate those types around their dependencies. The code-base is already using these types already.
The next step would be to improve type-safety, replacing a lot of 'any' with their actual expected types. This will require a lot more effort because it'll start introducing compile errors all over :)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:
  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

refactor: Simply imports
@faustbrian faustbrian self-requested a review December 28, 2018 14:40
@faustbrian
Copy link
Contributor

@paroxysm you need to restart your CircleCI build because it failed

@ghost ghost assigned faustbrian Dec 30, 2018
@ghost ghost added the review label Dec 30, 2018
@faustbrian faustbrian changed the title Export crypto typedefs refactor(crypto): export type definitions Dec 30, 2018
@faustbrian faustbrian merged commit d7d74bc into ArkEcosystem:develop Dec 30, 2018
@ghost ghost removed the review label Dec 30, 2018
@paroxysm paroxysm deleted the feat/export-crypto-typedefs branch December 30, 2018 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants