refactor(core-p2p): remove transactionsFromIds endpoint #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: apply v1 compatibility if the transaction version is 1; was previously not returning any results for v1 transactions due to missing `id` * fix: regex now accepts only exactly 64 hex chars per id (as tx id length is 64 chars); was previously allowing any 32+ character value including non-hex characters * fix: return `success: false` if no valid ids were passed; was previously returning the raw query syntax error from the db in the response * fix: change `row.block_id` to `row.blockId` so the block id for each tx is returned; previously block id was undefined and omitted from the response
alessiodf
changed the title
alessiodf
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1911 +/- ##
===========================================
+ Coverage 39.38% 39.55% +0.17%
===========================================
Files 350 350
Lines 7658 7624 -34
Branches 1166 1130 -36
===========================================
Hits 3016 3016
+ Misses 4628 4595 -33
+ Partials 14 13 -1
Continue to review full report at Codecov.
|
No longer necessary
No longer used
alessiodf
changed the title
faustbrian
approved these changes
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #1910 by
sanitising the tx ids and applies v1 compatibility where neededremoving the transactionsFromIds endpoint as it is no longer requiredTypes of changes
Checklist
Further comments
I'm not sure if this will have any implications if a block is received with headers only, since it is untested.After talking with @supaiku0 it seems header-only blocks aren't used in v2 anymore so the whole endpoint is no longer needed.