-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export and use core-database-postgres typedefs #1905
Export and use core-database-postgres typedefs #1905
Conversation
refactor: Remove un-used SPV.connection property refactor: Remove ConnectionInterface.connection property. This available in the 'options' object that's passed via constructor. refactor: Use inline-initialization instead of constructor initialization for concise code, unless we're accessing constructor parameters.
refactor: more inline-initialization vs constructor refactor: Removed some redundant vars in core-api Repositories, use inherited references instead.
The mentioned issues will be taken core of by #1573. There is still a lot of old code in it written by someone else that will refactored. In the end the There is tons of refactoring and especially improvements to the plugin system and structure in the pipeline now that JavaScript is gone but that will take time. |
@paroxysm conflicts |
…core-database-postgres-typedefs # Conflicts: # packages/core-database-postgres/src/connection.ts # packages/core-database-postgres/src/index.ts # packages/core-database-postgres/src/spv.ts # packages/core-database/src/interface.ts # packages/core-database/src/manager.ts
@faustbrian Great! There's definitely some tech debt that needs to be addressed |
@faustbrian I've addressed the conflicts. |
Proposed changes
resolves #1791
This refactor has exposed some strange design decisions made. There's some methods that are on the postgres implementation of the
Connection
interface that can be moved into an abstract class.PS. We probably should break out the business logic in
Connection
out into Services that leverage the connection and repositories so we're separating concernsTypes of changes
Checklist