Set default timeout on EpicsSignalBase #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default timeout on [`EpicsSignalBase`](bluesky/ophyd#917)
gfabbris
reviewed
Oct 7, 2020
| @@ -81,6 +81,7 @@ | |||
| #RE.msg_hook = ts_msg_hook | |||
| from bluesky.simulators import summarize_plan | |||
|
|
|||
| # set default timeout for all EpicsSignal connections & communications | |||
| # set default timeout for all EpicsSignalBase connections & communications | |||
| import ophyd | |||
There was a problem hiding this comment.
Do you need to import ophyd?
|
No. Remove that line.
…On Wed, Oct 7, 2020, 5:57 PM Gilberto Fabbris ***@***.***> wrote:
***@***.**** commented on this pull request.
Looks good.
------------------------------
In profile_bluesky/startup/instrument/framework/initialize.py
<#35 (comment)>
:
> @@ -81,6 +81,7 @@
#RE.msg_hook = ts_msg_hook
from bluesky.simulators import summarize_plan
-# set default timeout for all EpicsSignal connections & communications
+# set default timeout for all EpicsSignalBase connections & communications
import ophyd
Do you need to import ophyd?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMH7XQB4AVOPQKWJXT3SJTW43ANCNFSM4SGEF2VQ>
.
|
|
I think this can just be merged, correct? |
|
Yes. There will be another change coming for this based on a change I made
in ophyd today. For now, merge
…On Tue, Nov 3, 2020, 4:45 PM Gilberto Fabbris ***@***.***> wrote:
I think this can just be merged, correct?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMUMF7PA2KQD6VCD33WX3SOCBZJANCNFSM4SGEF2VQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default timeout on
EpicsSignalBaseto fix #34