fix refs components decoding

[RomanHotsiy]

The following ref was incorrectly resolved by the Pointer.parse method:

Pointer.parse("#/paths/~1user/application~1vnd.example%2Bjson/schema")
// returns ["paths", "/user", "application/vnd.example%2Bjson", "schema"]

Note that + in application/vnd.example%2Bjson is not decoded.
The reason is usage of decodeURI. Instead, decodeURIComponent should be used (tokens are components of the pointer)

[coveralls]

Coverage remained the same at 95.288% when pulling 5fe2988 on RomanGotsiy:patch-2 into dba71e2 on BigstickCarpet:master.

[coveralls]

Coverage remained the same at 95.288% when pulling 5fe2988 on RomanGotsiy:patch-2 into dba71e2 on BigstickCarpet:master.

[coveralls]

Coverage remained the same at 95.288% when pulling 5fe2988 on RomanGotsiy:patch-2 into dba71e2 on BigstickCarpet:master.

[coveralls]

Coverage remained the same at 95.288% when pulling 5fe2988 on RomanGotsiy:patch-2 into dba71e2 on BigstickCarpet:master.

[RomanHotsiy]

Hey @BigstickCarpet 🙌!
Could you please take a look at this?

Thanks in advance!

[JamesMessinger]

Hi @RomanGotsiy - sorry for taking so long to look at this. I've been super busy at work and haven't had any time.

I'm hesitant to merge this without a test, or at least an example of a schema that doesn't work without this change.

This block of code...
https://github.com/BigstickCarpet/json-schema-ref-parser/blob/9420095f8d717d1ec8372b66a01bbc0d6f903b50/lib/pointer.js#L168-L171

...is directly related to this block of code:
https://github.com/BigstickCarpet/json-schema-ref-parser/blob/9420095f8d717d1ec8372b66a01bbc0d6f903b50/lib/pointer.js#L193-L199

It seems like either both of them should change, or neither of them, but not just one or the other.

[RomanHotsiy]

Hey @BigstickCarpet!
No worries! I will add a test a bit later today!

Thanks

[JamesMessinger]

@RomanGotsiy - I reviewed the spec and found that you're correct. It should be encodeURIComponent and decodeURIComponent, rather than encodeURI and decodeURI. I extended the "special characters" tests to test for this. As expected, the tests failed. Once I merge this PR, they'll pass

[RomanHotsiy]

Nice! Thanks a lot for your work! 🙇