stop infinite recursion w/ crawling external refs #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a few cases of "Uncaught RangeError: Maximum call stack size exceeded"
Specifically if you have a schema with a circular reference like this:
And for whatever reason this gets dereferenced twice:
And of course this can happen without calling
dereference()
twice. In fact, I can construct a dereferenced schema myself like so:To resolve this we can modify the recursive function to track seen objects and return early if one is seen second time (or more).