diff --git a/.github/workflows/forms-flow-component-ci.yml b/.github/workflows/forms-flow-component-ci.yml index c7691b644..ef8a454eb 100644 --- a/.github/workflows/forms-flow-component-ci.yml +++ b/.github/workflows/forms-flow-component-ci.yml @@ -17,6 +17,7 @@ on: defaults: run: shell: bash + working-directory: ./forms-flow-components jobs: Forms-Flow-Components-CI: name: Run Tests and Lint Checks @@ -29,8 +30,6 @@ jobs: - name: Install dependencies run: | npm ci --force - working-directory: ./forms-flow-components - name: Run Tests run: | npm run test - working-directory: ./forms-flow-components \ No newline at end of file diff --git a/forms-flow-admin/src/components/roles/roles.tsx b/forms-flow-admin/src/components/roles/roles.tsx index f3c129c91..0db04c2d1 100644 --- a/forms-flow-admin/src/components/roles/roles.tsx +++ b/forms-flow-admin/src/components/roles/roles.tsx @@ -19,11 +19,7 @@ import Dropdown from "react-bootstrap/Dropdown"; import OverlayTrigger from "react-bootstrap/OverlayTrigger"; import Popover from "react-bootstrap/Popover"; import { toast } from "react-toastify"; -import { - KEYCLOAK_ENABLE_CLIENT_AUTH, - MULTITENANCY_ENABLED, -} from "../../constants"; -import { DEFAULT_ROLES } from "../../constants"; + import {removingTenantId} from "../../utils/utils.js"; import { TableFooter, CustomSearch } from "@formsflow/components"; @@ -60,7 +56,7 @@ const Roles = React.memo((props: any) => { React.useState(""); const [editCandidate, setEditCandidate] = React.useState(initialRoleType); const [disabled, setDisabled] = React.useState(true); - const [search, setSerach] = React.useState(""); + const [search, setSearch] = React.useState(""); const [permission, setPermission] = React.useState([]); const filterList = (filterTerm, List) => { @@ -120,7 +116,7 @@ const Roles = React.memo((props: any) => { const handlFilter = (e) => { if (e && e.key === 'Enter') { - setSerach(e.target.value); + setSearch(e.target.value); setRoles(filterList(e.target.value, props.roles)); } @@ -340,29 +336,8 @@ const Roles = React.memo((props: any) => { setDisabled(false); }; - const checkDefaultRoleOrNot = (role: any) => { - if (MULTITENANCY_ENABLED && tenantId) { - const roles = [ - `${tenantId}-designer`, - `${tenantId}-client`, - `${tenantId}-reviewer`, - `${tenantId}-admin`, - "formsflow-reviewer", - "formsflow-designer", - "formsflow-client", - "camunda-admin", - "Approver", - "clerk", - "designer", - ]; - return roles.includes(role); - } else { - return DEFAULT_ROLES.includes(role); - } - }; - const handleClearSearch = () => { - setSerach(""); + setSearch(""); let updatedRoleName = removingTenantId(props.roles,tenantId); setRoles(updatedRoleName); }; @@ -696,7 +671,7 @@ const Roles = React.memo((props: any) => { dataField: "id", text: {(t) => t("Actions")}, formatter: (cell, rowData, rowIdx, formatExtraData) => { - return checkDefaultRoleOrNot(rowData.name) ? null : ( + return (
{