Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NMOS Test Suite mock registries are HTTP/1.0 #120

Open
garethsb opened this issue Feb 1, 2019 · 4 comments
Open

NMOS Test Suite mock registries are HTTP/1.0 #120

garethsb opened this issue Feb 1, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@garethsb
Copy link
Contributor

garethsb commented Feb 1, 2019

I don't think the NMOS specs discuss differences between HTTP/1.1 and HTTP/1.0, or indicate a recommendation either way?

However, the fact that the test suite's Registries are currently HTTP/1.0 identified a bug in the HTTP implementation of cpprestsdk, which means it doesn't properly handle HTTP/1.0 servers that don't do "Connection: Keep-Alive". (Fix available at microsoft/cpprestsdk#1032.)

So, I'm not opposed to the test suite testing HTTP/1.0... but did it ought at least check HTTP/1.1 as well?

@andrewbonney
Copy link
Contributor

Fwiw I had a try replacing the basic Flask web server with Werkzeug (which as noted it at least partially uses anyway). Unfortunately this still returned an HTTP/1.0 response.

@andrewbonney andrewbonney added the enhancement New feature or request label Feb 1, 2019
@garethsb
Copy link
Contributor Author

garethsb commented Feb 1, 2019

There appears to be a SERVER_PROTOCOL config for Werkzeug if I understand my Googling correctly.

@andrewbonney
Copy link
Contributor

Yes, I came across that (at least in something testing related), but it seems to default to HTTP/1.1 anyway

@andrewbonney
Copy link
Contributor

I'm wondering if it might be necessary to provide instructions for use with a full WSGI compatible web server in order to achieve this (for example https://uwsgi-docs.readthedocs.io/en/latest/WSGIquickstart.html#deploying-flask). I've not seen anything concrete, but running the 'development' web server may only be capable of HTTP/1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants