Update autodiff::dual to give the same results as amrex::Real
#1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If AUTODIFF_STRICT_ASSOCIATIVITY is defined before including autodiff headers, optimizations that break the left-to-right associativity of + and * operators will be disabled. This uses more intermediate temporary assignments, but should produce the exact same values between identical code that uses `autodiff::dual` in place of `double`. From yut23/autodiff@d7e3e99
|
this is upstreamed here: autodiff/autodiff#352 |
|
all of the test_rhs diffs are roundoff error level |
zingale
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing with converting the
aprox*rates to use autodiff, I found a lot of instances where code templated withautodiff::dualwould give slightly different values than the same code templated withamrex::Real. It turns out to be due to some optimizations autodiff makes to speed up evaluation, which this PR disables to avoid any weird inconsistencies in the future.