move the fourth order center <-> average stuff to C++ #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all SDC tests pass: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2020-04-27-004/index.html blocked by #885 |
maxpkatz
reviewed
May 6, 2020
| @@ -289,23 +288,29 @@ Castro::construct_mol_hydro_source(Real time, Real dt, MultiFab& A_update) | |||
|
|
|||
| #if AMREX_SPACEDIM >= 2 | |||
| // construct the face-center interface states q_fc | |||
| AMREX_PARALLEL_FOR_4D(nbx, NQ, i, j, k, n, { | |||
| bool test = (n == QGC) || (n == QTEMP); | |||
| const int* lo_bc = phys_bc.lo(); | |||
There was a problem hiding this comment.
phys_bc is sized AMREX_SPACEDIM so we need to avoid dereferencing it outside those bounds. There are a few other instances of that below.
maxpkatz
reviewed
May 6, 2020
Source/hydro/Castro_hydro.H
Outdated
| void make_cell_center(const Box& bx, | ||
| Array4<Real const> const& U, | ||
| Array4<Real> const& U_cc, | ||
| GpuArray<int, 3>& domlo, GpuArray<int, 3>& domhi); |
There was a problem hiding this comment.
domlo and domhi should be const in all of these routines
maxpkatz
reviewed
May 6, 2020
|
I think I addressed all the comments |
maxpkatz
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist
CHANGESfile has been updated