Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scripts and input files for diffusion test #3012

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

zhichen3
Copy link
Collaborator

PR summary

  1. corrects README
  2. Update analysis script
  3. add spherical geometry input file

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zhichen3
Copy link
Collaborator Author

spherical input file assumes 1 level (max_level=0) for now.

@zingale
Copy link
Member

zingale commented Dec 13, 2024

maybe we should rename cyl in the inputs file to axisymmetric, so it is clear.

Note that in Sedov, we also use cyl to mean a cylindrical explosion in 2D Cartesian and sph to mean a spherical explosion in 2D axisymmetric.

@zhichen3
Copy link
Collaborator Author

done

@zingale zingale merged commit 0e11b33 into AMReX-Astro:development Dec 13, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants