New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name variables to geom when its amrex::Geometry to avoid confusion in Derive.H/.cpp #2989

Merged

zingale merged 1 commit into AMReX-Astro:development from zhichen3:correct_goem_variable_name

Nov 8, 2024

Collaborator

zhichen3 commented Nov 7, 2024

PR summary

correct variable names from geomdata -> geom when its actually amrex::Geometry

PR motivation

PR checklist

test suite needs to be run on this PR
this PR will change answers in the test suite to more than roundoff level
all newly-added functions have docstrings as per the coding conventions
the CHANGES file has been updated, if appropriate
if appropriate, this change is described in the docs


          name variable to geom when its amrex::Geometry to avoid confusion

ac9568b

zhichen3 marked this pull request as ready for review

November 7, 2024 21:30

Member

zingale commented Nov 8, 2024

quick tests pass:
http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2024-11-08-001/index.html

zingale approved these changes

View reviewed changes

zingale merged commit b38a018 into AMReX-Astro:development

25 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet