refactor SDC Newton solver to use burn_t #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this cleans up some interfaces and reduces memory requirements.
|
test suite diffs are roundoff: |
zingale
changed the title
|
this is ready for review. I will follow it up with more cleaning, but I wanted to get these changes in first. |
|
okay, test suite passes now with no diffs: |
maxpkatz
reviewed
Oct 6, 2023
Source/sdc/Castro_sdc_util.H
Outdated
| // reevaluating the reactions and { doing the full step update | ||
| single_zone_react_source(U_new, R_full, burn_state); | ||
| // we solved our system to some tolerance, but let's be sure | ||
| // we are conservative by reevaluating the reactions and { |
There was a problem hiding this comment.
why?
The idea is that we might have done it one a little bit at a time, and next we want to do it in terms of averages and as a single update
There was a problem hiding this comment.
oh... I see what you mean ;)
maxpkatz
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this cleans up some interfaces and reduces memory requirements.
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate