Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] loosen nse constraint only after max subcycle is reached #2435

Draft
wants to merge 18 commits into
base: development
Choose a base branch
from

Conversation

zhichen3
Copy link
Collaborator

@zhichen3 zhichen3 commented May 2, 2023

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

Sorry, something went wrong.

@zingale
Copy link
Member

zingale commented Jul 26, 2024

do we still want to consider this?

@zhichen3
Copy link
Collaborator Author

I think its a reasonable thing to do if we were to use these loosen-constraint parameters. But right now I tend to not use them because I think it would make the constraint "too loose".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants