You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It looks like we adding the pressure to the momntum flux in 1-d Cartesian in scale_flux(), but I think this is wrong -- it should already be added since mom_flux_has_p is always true for Cartesian. So I think that we need to remove this addition in advection_util.cpp
The text was updated successfully, but these errors were encountered:
I agree that the addition should be removed. #2468 makes mom_flux_has_p to return true instead of false for 1D cartesian, which is certainly the correct behavior. So now pressure is already included in the definition of flux in compute_flux_q
addresses #2803 . In #2468, we modified mom_flux_has_p to include pressure in momentum flux with 1d cartesian, so we don't need to scale pressure again scale_flux.
It looks like we adding the pressure to the momntum flux in 1-d Cartesian in
scale_flux()
, but I think this is wrong -- it should already be added sincemom_flux_has_p
is always true for Cartesian. So I think that we need to remove this addition inadvection_util.cpp
The text was updated successfully, but these errors were encountered: