Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

still have issues with pressure in 1-d momentum fluxes #2803

Closed
zingale opened this issue Mar 25, 2024 · 2 comments
Closed

still have issues with pressure in 1-d momentum fluxes #2803

zingale opened this issue Mar 25, 2024 · 2 comments

Comments

@zingale
Copy link
Member

zingale commented Mar 25, 2024

It looks like we adding the pressure to the momntum flux in 1-d Cartesian in scale_flux(), but I think this is wrong -- it should already be added since mom_flux_has_p is always true for Cartesian. So I think that we need to remove this addition in advection_util.cpp

@zingale
Copy link
Member Author

zingale commented Apr 6, 2024

it looks like this was missed in #2468

@zhichen3
Copy link
Collaborator

I agree that the addition should be removed. #2468 makes mom_flux_has_p to return true instead of false for 1D cartesian, which is certainly the correct behavior. So now pressure is already included in the definition of flux in compute_flux_q

zingale pushed a commit that referenced this issue Nov 17, 2024
addresses #2803 . In #2468, we modified mom_flux_has_p to include pressure in momentum flux with 1d cartesian, so we don't need to scale pressure again scale_flux.
@zingale zingale closed this as completed Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants