Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation time performance profiling of feature calculation #106

Closed
fedorov opened this issue Sep 9, 2016 · 10 comments
Closed

Computation time performance profiling of feature calculation #106

fedorov opened this issue Sep 9, 2016 · 10 comments
Labels

Comments

@fedorov
Copy link
Collaborator

fedorov commented Sep 9, 2016

Some information that gives user the idea about the relative computation time could be helpful

@JoostJM
Copy link
Collaborator

JoostJM commented Oct 20, 2016

I did a profiling using PyCharm on the Lung2 testcase, using the current master and all features enabled, with only original image, here is a snapshot of the most time intensive functions:

image

@JoostJM
Copy link
Collaborator

JoostJM commented Oct 20, 2016

Call diagram (with time needed):

diagram

@fedorov
Copy link
Collaborator Author

fedorov commented Oct 20, 2016

The last one looks very helpful! Nice work!

@JoostJM
Copy link
Collaborator

JoostJM commented Oct 20, 2016

As you can see, glcm appears to be the main bottleneck. Today, I tried a different approach to calculating the matrix and this resulted in about 5x speed increase for glcm alone (~3-4x faster for the whole calculation).

@fedorov
Copy link
Collaborator Author

fedorov commented Oct 20, 2016

Sounds promising! Also, thank you for going over the open issues and cleaning up the list. This is a good thing to do prior to the release. I have several urgent deadlines and a lot of work that needs to be done in the next week or so, so I apologize I won't have time to look into this soon.

@JoostJM
Copy link
Collaborator

JoostJM commented Oct 20, 2016

Addressed by #135

@JoostJM
Copy link
Collaborator

JoostJM commented Nov 16, 2016

Implementation of C which yields a large improvement: #158, total computation time was 13101 ms.
Here, shape and glrlm are not yet implemented, but code has two extra feature classes compared to profiling shown in this issue

@JoostJM
Copy link
Collaborator

JoostJM commented Nov 24, 2016

With all matrix calculation in C, as well as surface area calculation, total computing time for 5 test cases is now just over 6 seconds

@JoostJM
Copy link
Collaborator

JoostJM commented Nov 25, 2016

Call graph using Cmatrices #158 and reduction of SimpleITK calls proposed in #167:

snapshot cmatrices

@JoostJM
Copy link
Collaborator

JoostJM commented Feb 17, 2017

Resolved by #202

@JoostJM JoostJM closed this as completed Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants