Skip to content

Commit

Permalink
BUG: uncomment algorithm details initialization
Browse files Browse the repository at this point in the history 
This apparently was committed by accident earlier ...
  • Loading branch information
@fedorov
fedorov authored Nov 17, 2018
1 parent 2e60df1 commit f03145b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions labs/pyradiomics-dcm/pyradiomics-dcm.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,12 +530,10 @@ def main():
segmentationLocation.CodeMeaning).getDict()

# AlgorithmIdentification
'''
m.m["Measurements"][-1]["measurementAlgorithmIdentification"] = {}
m.m["Measurements"][-1]["measurementAlgorithmIdentification"]["AlgorithmName"] = "https://github.com/Radiomics/pyradiomics"
m.m["Measurements"][-1]["measurementAlgorithmIdentification"]["AlgorithmVersion"] = pyradiomicsVersion
m.m["Measurements"][-1]["measurementAlgorithmIdentification"]["AlgorithmParameters"] = [json.dumps(extractor.settings)]
'''

m.m["observerContext"] = {}
m.m["observerContext"]["ObserverType"] = "DEVICE"
Expand Down

5 comments on commit f03145b

@fedorov
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoostJM I am sorry, I messed up - this chunk of code was supposed to be in the release. I am very sorry I commented it out by mistake... It is quite important, unfortunately. I don't know how it happened, and I discovered this today by accident.

Do you mind if I spend a bit more time to look over and test things again, and then make another patch release?

@JoostJM
Copy link
Collaborator

@JoostJM JoostJM commented on f03145b Nov 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedorov Sure, making a new release is not so difficult. but what do you mean precisely by "patch release"?
If you want, I can make a 2.1.1.post1 release?

@fedorov
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just meant a release with the last component of the release number to be changed. I believe the 3 numbers are referred to as major.minor.patch. sorry for the confusion! Will look into it later today, thanks!

@JoostJM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fedorov, it's indeed major.minor.patch, but I was not sure that's what you were referring to.
When you're ready, I can make a 2.1.2 release.

PyPi also supports post-release patches (defined by the postN suffix), which, as far as I know, is intended for a small update. Usually this designated the nth commit after the release, where the commit itself is not a new release.

PyRadiomics installed from source does this automatically (and actually then also appends the git tag hash), but the CI is setup so, that this does not trigger a 'release' (i.e. publication to PyPi and Conda).

Still, it is possible to make such a release (PyPi supports a version like 2.1.1.post1), it just means that I would have to add a tag that specifies this specific version.

@fedorov
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoostJM I did a quick check, and it looks good to me with the patch. Please let me know if you would like me to make the new release, I hate to take your time due to my sloppiness.

Please sign in to comment.