Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReconnectBoundaryB3 does not conserve energy #131

Closed
bprather opened this issue Dec 13, 2024 · 0 comments · Fixed by #132
Closed

ReconnectBoundaryB3 does not conserve energy #131

bprather opened this issue Dec 13, 2024 · 0 comments · Fixed by #132

Comments

@bprather
Copy link
Contributor

Perhaps part of the reason that setting boundaries/reconnect_B3_XX was so calming to simulations was that it was leaking magnetic energy.

Basically, the reconnection function reduces the local magnetic pressure by reducing the B3 magnetic field component, but does not then update the fluid primitive variables to move that energy into the fluid internal energy. Since the primitive variables are the next values to be used, the total energy is effectively reduced, disappearing the magnetic field's energy into nothing instead of shifting it to the fluid.

This can be fixed by simply calling U->P on affected zones to update the fluid primitive variables in light of the new magnetic field, PR coming soon. Thanks to @hyerincho for finding this!

Note this doesn't affect CancelBoundaryU3 and CancelBoundaryT3 -- though, they had stability issues of their own addressed in #126

@bprather bprather linked a pull request Jan 7, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant