Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3.12 compatibility will require lxml 5.0.0 #29

Closed
APCBoston opened this issue Jun 15, 2023 · 3 comments · Fixed by #37
Closed

Python3.12 compatibility will require lxml 5.0.0 #29

APCBoston opened this issue Jun 15, 2023 · 3 comments · Fixed by #37

Comments

@APCBoston
Copy link
Contributor

While working on #28, I learned that CPython3.12 cannot build lxml < 5.0.0. See streamlink/streamlink#5336
@JennToo
Copy link
Member

JennToo commented Jun 15, 2023

Interesting, we can probably just widen this range on the next release:

netconf_client/pyproject.toml

Line 20 in c35237a

lxml = "^4.6.3"

@APCBoston
Copy link
Contributor Author

I suspected as much; I haven't seen anything that suggests breaking changes in lxml 5, just wanted to note this here to prevent future pain.

@JennToo
Copy link
Member

JennToo commented Jun 15, 2023

Looks like lxml 5 isn't released yet. Once it does I'll go widen it and do a release. I'm hesitant to per-emptively widen the range without having a released version to test it against.

@alangefe alangefe mentioned this issue Feb 7, 2024
Merged
@Kyle-Neale Kyle-Neale mentioned this issue Sep 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Allow lxml 5.x and require python >= 3.8 alangefe/netconf_client
2 participants
@JennToo @APCBoston