mysql: Handle tables that are reserved words #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping table names represented by `%s` in backticks so tables names that are also reserved words don't cause issues. These 2 locations have impacted our project. There are more in this file but they have not impacted us yet so I have left them untouched. I also updated the call to `$this->Execute()` in the first case. PHP is case insensitive to this, but not all IDE's are so this should help those.
By all means, feel free to fix them too |
dregad
approved these changes
Oct 15, 2021
dregad
changed the title
|
See @peterdd's comment 72ffec3#r69702567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping table names represented by
%sin backticks so tables names that are also reserved words don't cause issues.These 2 locations have impacted our project. There are more in this file but they have not impacted us yet so I have left them untouched.
I also updated the call to
$this->Execute()in the first case. PHP is case insensitive to this, but not all IDE's are so this should help those.