Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better default for device used to _save_ model in run_train #635

Open
bernstei opened this issue Oct 11, 2024 · 2 comments
Open

better default for device used to _save_ model in run_train #635

bernstei opened this issue Oct 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bernstei
Copy link
Collaborator

Right now mace_run_train by defaults saves gpu-format models, unless --save_cpu is explicitly passed. However, those cannot be converted to cpu format without a gpu machine, and going the other way is always possible. I think it would be more helpful to by default save to cpu format.

One option would be to default to saving a cpu model, and replacing the flag with --save_gpu. Another, more versatile option might be to do something like

add_argument("--save_device", choices=["cpu", "gpu"], default="cpu")
@wcwitt
Copy link
Collaborator

wcwitt commented Oct 11, 2024

Related: #130.

@ilyes319
Copy link
Contributor

ilyes319 commented Oct 11, 2024

Somehow I never merged it because I was scared it would crash everyone's training.
I think Noam's way is better. I will leave the save_cpu for now and just depricate it and add Noam's way as default.

@ilyes319 ilyes319 added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants