Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test package correctness by trying to build #161

Open
aidanheerdegen opened this issue Nov 12, 2024 · 1 comment
Open

Test package correctness by trying to build #161

aidanheerdegen opened this issue Nov 12, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request priority:medium

Comments

@aidanheerdegen
Copy link
Member

It would be good to check package correctness by trying to build the package as part of a CI check.

This was precipitated by a PR which changed the source URL of a package such that it would not have built correctly with a CI user.

And while this sort of error could be checked for without building the package, there may be other problems that would not be picked up. Especially if there were changes in other packages that might affect the package being changed.

Some problems to consider

  1. We only want to build packages that have changed
  2. Builds can take a long time

The time taken might mean this is a check we invoke with a ChatOps comment rather than run automatically with every change. Not sure.

@CodeGat CodeGat self-assigned this Nov 12, 2024
@CodeGat
Copy link
Member

CodeGat commented Nov 12, 2024

Seems fair enough to me. The only disadvantage with ChatOps stuff is that it doesn't prevent/allow merging explicitly like a check does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium
Projects
Status: New Issues 🌅
Development

No branches or pull requests

2 participants