Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PR preview workflow still complete successfully when different PRs open at the same time #751

Open
atteggiani opened this issue Aug 28, 2024 · 0 comments · May be fixed by #876
Open
Assignees

Comments

@atteggiani
Copy link
Contributor

What

Currently the deploy workflow gets cancelled if another deploy workflow gets called.
This is good because it avoids a duplication of tasks (the second workflow would overwrite the first so there is no point finishing to run the first).

However, currently the PR previews are attached to a single workflow run, and if the workflow gets cancelled, the deployment preview fails.

Solution

Re-structure the workflow so that, after the deployment of all PRs (coming from any deployment workflow), it issues comments to all the PR deployed (not only to the one that triggered the workflow).

@atteggiani atteggiani self-assigned this Aug 28, 2024
@atteggiani atteggiani removed their assignment Jan 23, 2025
@atteggiani atteggiani linked a pull request Feb 4, 2025 that will close this issue
2 tasks
@atteggiani atteggiani self-assigned this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant