Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Highlighting breaks on default light media #7

Closed
Muhammed-Abdullah-Shaikh opened this issue Aug 29, 2024 · 6 comments · Fixed by #8
Closed

Code Highlighting breaks on default light media #7

Muhammed-Abdullah-Shaikh opened this issue Aug 29, 2024 · 6 comments · Fixed by #8
Assignees
Labels
good first issue Good for newcomers

Comments

@Muhammed-Abdullah-Shaikh
Copy link
Collaborator

The default browser appearance is light.
When switched to dark mode, using the theme icon, the code highlighting break.

Expected Behavior

The background color in pre tag should be dark

Actual Behavior

The background color in pre tag is light even if dark dome is selected

Steps to Reproduce the Problem

N.A.

Any logs, error output, etc?

Current Behavior:
image

Expected should be

image

What versions of software are you using?

  • Furo50 Version: 1.0.0-alpha.1
  • Platform: Windows10
  • Browser: Microsoft Edge 128.0.2739.42
Copy link

Hey @Muhammed-Abdullah-Shaikh! Thanks for your contribution. Please wait while the maintainers review your message.

Copy link

Hey @Muhammed-Abdullah-Shaikh! Thanks for creating this issue. Please wait while the maintainers review your issue.

Repository owner deleted a comment Aug 29, 2024
@ABD-01 ABD-01 added the good first issue Good for newcomers label Aug 29, 2024
Copy link

Hey @ABD-01! Thanks for your contribution. Please wait while the maintainers review your message.

Copy link

Hey @ABD-01! Thanks for your contribution. Please wait while the maintainers review your message.

@ABD-01
Copy link
Owner

ABD-01 commented Aug 29, 2024

Ignore the bot.
I need to fix that workflow

@Muhammed-Abdullah-Shaikh
Copy link
Collaborator Author

I believe it is caused by

pre {
border: 1px solid var(--color-background-border); /* light: #dee2e6 dark: #495057*/
background-color: #f8f9fa;
}
@media (prefers-color-scheme: dark) {
body:not([data-theme="light"]) pre {
background-color: inherit;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants