Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Folia detection method more resilient to shading the server platform #5

Open
A248 opened this issue Oct 5, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@A248
Copy link
Owner

A248 commented Oct 5, 2024

Currently, MorePaperLib checks for the presence of a certain Folia API class to determine whether Folia is being used.

This can break if another plugin has shaded the entire Folia server platform, which is most certainly a bug in its own right and drastic for the server.

Nevertheless, this means a MorePaperLib-dependent plugin can sometimes break as an additional consequence. See, for example, A248/LibertyBans#283 . To resolve this, we might check for methods on existing classes (like the method mentioned in the linked NoSuchMethodError) instead of a certain class on the classpath.

@A248 A248 added enhancement New feature or request good first issue Good for newcomers labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant