Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Allow importing Alyle UI in sub-modules #87

Open
uplink42 opened this issue Jul 12, 2019 · 1 comment
Open

Suggestion: Allow importing Alyle UI in sub-modules #87

uplink42 opened this issue Jul 12, 2019 · 1 comment
Labels

Comments

@uplink42
Copy link

uplink42 commented Jul 12, 2019

Bug, feature request, or proposal:

feature request

What is the expected behavior?

I've recently discovered Alyle UI and it's a great library with many useful components. However from what I understand from the documentation you are only able to import the LyThemeModule in the root module. This adds a significant weight to the main bundle size in my project, especially because I only actually use the Alyle components inside lazy-loaded modules (i.e the admin sections).

So basically, the main bundle is forced to include Alyle and chroma-js but most of my app doesn't actually use it. It's a bit of a letdown, considering the homepage is a public-facing app where speed and loading times are important. For example, with Angular Material Design I only load the components for the admins section and they don't put any extra weight on the initial bundle:

image

I hope you can consider this sometime. Great work btw.

@Enlcxx Enlcxx added the feature label Jul 13, 2019
@Enlcxx
Copy link
Member

Enlcxx commented Jul 13, 2019

Yes, this will definitely have support for lazy-loading, so it will be available for version 3. It is very likely that the API can change.

@Enlcxx Enlcxx mentioned this issue Aug 4, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants