Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider's thumbs are not clickable/dragable in angular 11 with core-js@3 #142

Open
Exlord opened this issue Dec 28, 2020 · 9 comments
Open
Labels

Comments

@Exlord
Copy link

Exlord commented Dec 28, 2020

🪲 Bug report

Describe the bug

Slider's thumbs are not clickable/dragable in angular 11 with core-js@3

Minimal Reproduction

Steps to reproduce the behavior:
https://stackblitz.com/edit/angular-11-alyleui-slider

Which versions of Angular, Alyle UI, OS, TypeScript, browsers are affected?

Alyle UI Version:
"@alyle/ui": "^10.4.0",

Angular Version:


Angular CLI: 11.0.5
Node: 14.15.0
OS: win32 x64

Angular: 11.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.5
@angular-devkit/build-angular   0.1100.5
@angular-devkit/core            11.0.5
@angular-devkit/schematics      11.0.5
@angular/cdk                    11.0.3
@angular/material               11.0.3
@schematics/angular             11.0.5
@schematics/update              0.1100.5
rxjs                            6.6.3
typescript                      4.0.5

If I change the core-js to v2 it works in the demo, but angular 11 installs core-js@3

@Enlcxx Enlcxx added the bug label Dec 28, 2020
@janhocevar
Copy link

Have this been worked on? Also not working with Angular v12.0.0-next.8

@janhocevar
Copy link

This is fixed if you import hammerjs package wherever in the app

import 'hammer.js';

@Exlord
Copy link
Author

Exlord commented Apr 12, 2021

This is fixed if you import hammerjs package wherever in the app

import 'hammer.js';

I already had hammer.js imported

@ncanino
Copy link

ncanino commented Nov 29, 2023

Solved? I have a similar problem. When importing carousel as remote on Shell, touch doesn't work

@Enlcxx
Copy link
Member

Enlcxx commented Nov 30, 2023

Solved? I have a similar problem. When importing carousel as remote on Shell, touch doesn't work

@ncanino What version of Angular and Alyle UI are you using?

@ncanino
Copy link

ncanino commented Nov 30, 2023

Angular 15.2.7 This is both on the remote and on the Shell. The nice thing is that even if I don't use the remote and move the component on the Shell the touch doesn't work. It would be best not to apply the ng-reflect

@Enlcxx
Copy link
Member

Enlcxx commented Dec 13, 2023

@ncanino carousel seems to have problems importing hammer js in remote or in shell.
So the only solution for carousel is not to use the touch or replace the hammer js with a native one so that the touch works.

@ncanino
Copy link

ncanino commented Dec 13, 2023

@Enlcxx Thanks so much for the information. Where do I find directions for using a native one? Should I replace hammer.js from remote or import to shell?

@Enlcxx
Copy link
Member

Enlcxx commented Dec 14, 2023

@ncanino You can try importing hammerjs to the shell, if it doesn't work I will have to make internal changes to the carousel, just as I did with the slider, the slider no longer depends on hammer.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants