Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passKeyring does not implement Keyring (missing GetMetadata method) #47

Closed
chrisgilmerproj opened this issue Jun 17, 2019 · 4 comments
Closed

Comments

@chrisgilmerproj
Copy link

While attempting to update my go dependencies for aws-vault and keyring I ran across this issue.

$ go get github.com/99designs/keyring
go: finding github.com/99designs/keyring latest
# github.com/99designs/keyring
../../go/pkg/mod/github.com/99designs/[email protected]/pass.go:34:3: cannot use pass (type *passKeyring) as type Keyring in return argument:
        *passKeyring does not implement Keyring (missing GetMetadata method)

My guess is that #29 from @lox forgot to add this here and now it's a problem when loading it with go modules.

@philpennock
Copy link
Contributor

#29 was my code and the problem is that pass.go did not exist when I wrote the PR, so I did not add support for the method. Between my writing the patch and the patch being landed, more backends were added to keyring.

@chrisgilmerproj
Copy link
Author

@philpennock - Would you be able to fix this? Or should I take a stab at it? In the interim it just means I can't get newer versions of this code through my build pipeline.

@chrisgilmerproj
Copy link
Author

Actually, it appears that #46 addresses the issue. I'll wait to see if that gets merged.

@chrisgilmerproj
Copy link
Author

Appears that this was resolved when #46 merged. Thanks all for your great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants