Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-vault v5.0.0 removes default profile block header #475

Closed
mbacchi opened this issue Dec 22, 2019 · 3 comments
Closed

aws-vault v5.0.0 removes default profile block header #475

mbacchi opened this issue Dec 22, 2019 · 3 comments

Comments

@mbacchi
Copy link

mbacchi commented Dec 22, 2019

When adding a new credential to aws-vault on v5.0.0, it removes the [default] block header.

$ aws-vault --version
v5.0.0
$ aws-vault list
Profile                  Credentials              Sessions                 
=======                  ===========              ========                 
default                  default (missing)        -                        
user1                    user1                    1577058481 (mfa) 
$ cat ~/.aws/config 
[default]
output=json
region=us-east-1

[profile user1]
mfa_serial=arn:aws:iam::XXX:mfa/user1
region=us-east-2

$ aws-vault add experiment_user1
Enter Access Key ID: XXX
Enter Secret Access Key: XXX
Added credentials to profile "experiment_user1" in vault

$ cat ~/.aws/config 
output=json
region=us-east-1

[profile user1]
mfa_serial=arn:aws:iam::XXX:mfa/user1
region=us-east-2

[profile experiment_user1]


@dustydecapod
Copy link
Contributor

I had this issue a couple days ago, can confirm. I'm going to look into what's causing this.

@dustydecapod
Copy link
Contributor

The INI lib being used doesn't put the header over default values by default, so this ended up being a one-line change to configure it to output the header.

I've created PR #476 to address this.

@mtibben
Copy link
Member

mtibben commented Dec 24, 2019

Fixed in #476

@mtibben mtibben closed this as completed Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants