fix(Button): remove default type

8base · Mar 12, 2019 · f856f52 · f856f52
1 parent 8de3275
commit f856f52
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/components/Button/Button.js b/src/components/Button/Button.js
@@ -36,7 +36,7 @@ class Button extends Component<ButtonProps> {
     variant: 'raised',
     color: 'primary',
     size: 'md',
-    type: 'button',
+    tagName: 'button',
   };
 
   onClick = (event: *) => {
@@ -46,13 +46,12 @@ class Button extends Component<ButtonProps> {
   }
 
   render() {
-    const { children, type, loading, ...rest } = this.props;
+    const { children, tagName, loading, ...rest } = this.props;
 
     return (
       <ButtonTag
-        tagName="button"
         { ...rest }
-        type={ type }
+        tagName={ tagName }
         loading={ loading }
         onClick={ this.onClick }
         aria-busy={ Boolean(loading).toString() }

diff --git a/src/components/Button/Button.test.js b/src/components/Button/Button.test.js
@@ -25,7 +25,6 @@ describe('<Button />', () => {
   onClick={[Function]}
   size="md"
   tagName="button"
-  type="button"
   variant="raised"
 >
   <span

diff --git a/src/components/Button/Button.theme.js b/src/components/Button/Button.theme.js
@@ -57,6 +57,7 @@ const getSquaredStyle = (props: *) => {
 
 const [ButtonTag, theme] = createThemeTag(name, ({ COLORS, SIZES }: *) => ({
   root: (props) => ({
+    appearance: 'none',
     outline: 'none',
     textAlign: 'center',
     textDecoration: 'none',