fix(DateInput): use empty string instead of null for text value

8base · May 21, 2019 · 43d300e · 43d300e
1 parent 9344f1e
commit 43d300e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/DateInput/DateInput.js b/src/components/DateInput/DateInput.js
@@ -42,7 +42,7 @@ class DateInput extends React.Component<DateInputProps, DateInputState> {
   componentDidUpdate(prevProps: DateInputProps) {
     const { value, withTime } = this.props;
 
-    if (value && value !== prevProps.value) {
+    if (value !== prevProps.value) {
       this.setState({
         textValue: utils.fromISOToViewFormat(value, withTime),
       });

diff --git a/src/components/DateInput/DateInput.test.js b/src/components/DateInput/DateInput.test.js
@@ -126,7 +126,7 @@ describe('<DateInnput />', () => {
     wrapper.find(Dropdown.Head).simulate('click');
 
     expect(wrapper.find(DatePicker).props().selected).toBeNull();
-    expect(wrapper.find(Input).props().value).toBeNull();
+    expect(wrapper.find(Input).props().value).toEqual('');
   });
 
 

diff --git a/src/components/DateInput/DateInput.utils.js b/src/components/DateInput/DateInput.utils.js
@@ -15,10 +15,10 @@ export const fromISOToViewFormat = (value: ?string, withTime: ?boolean) => {
     if (value.isValid) {
       value = value.toFormat(withTime ? DATETIME_FORMAT : DATE_FORMAT);
     } else {
-      value = null;
+      value = '';
     }
   } else {
-    value = null;
+    value = '';
   }
 
   return value;