fix(Tag): inside ref

8base · Mar 26, 2019 · 226617d · 226617d
1 parent d007567
commit 226617d
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/common/Tag/Tag.js b/src/common/Tag/Tag.js
@@ -25,6 +25,7 @@ type TagProps = {|
   onKeyUp?: (event?: SyntheticKeyboardEvent) => void,
   onKeyDown?: (event?: SyntheticKeyboardEvent) => void,
   onSubmit?: () => void,
+  onScroll?: () => void,
   options?: Array<Object>,
   placeholder?: string,
   rows?: number | string,
@@ -62,6 +63,7 @@ const COLLECTED_PROPS = [
   'onKeyUp',
   'onKeyDown',
   'onSubmit',
+  'onScroll',
   'options',
   'placeholder',
   'rows',
@@ -94,6 +96,7 @@ const HTML_TAGS = [
   'label',
   'nav',
   'img',
+  'pre',
 ];
 
 const collectProps = (props) => pickBy(props, (value, name) => COLLECTED_PROPS.indexOf(name) !== -1 || /^data-/.test(name));
@@ -108,7 +111,11 @@ class Tag extends PureComponent<TagProps> {
 
     const collectedProps = HTML_TAGS.indexOf(TagComponent) === -1 ? props : collectProps(props);
 
-    return <TagComponent { ...collectedProps } ref={ props.insideRef } />;
+    if (HTML_TAGS.indexOf(TagComponent) !== -1) {
+      collectedProps.ref = props.insideRef;
+    }
+
+    return <TagComponent { ...collectedProps } />;
   }
 }