Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bar ordering #1903

Closed
jimmyjones2 opened this issue Nov 12, 2014 · 4 comments · Fixed by #1968 · May be fixed by enterstudio/kibana#74, xhad/scc#74 or 82ndAirborneDiv/kibana#35
Closed

Bar ordering #1903

jimmyjones2 opened this issue Nov 12, 2014 · 4 comments · Fixed by #1968 · May be fixed by enterstudio/kibana#74, xhad/scc#74 or 82ndAirborneDiv/kibana#35
Assignees
@stormpython
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation PR sent
Milestone
4.0.0-BETA3

Comments

@jimmyjones2
Copy link
Contributor

In Kibana 4 beta 2 Visualize, aggregation by terms, the bars are ordered lexicographically. Kibana 3 had the option to order them by count as well, so the tallest bar was first/last.
@stormpython
Copy link
Contributor

@jimmyjones2 could you provide an example of what you mean when you say that terms aggregations for vertical bar charts are ordered lexicographically. I haven't been able to reproduce that.

Bar charts for terms aggregations should be ordered by count. For example:
screen shot 2014-11-18 at 7 22 25 pm

@jimmyjones2
Copy link
Contributor Author

Maybe it's just with numbers:
screenshot from 2014-11-18 21 03 49

@stormpython
Copy link
Contributor

@jimmyjones2 thank you. This really clears this up. I am adding a bug tag to this and assigning myself. I know whats going on here, so I will submit a pull request soon to fix this.

@stormpython stormpython added bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation and removed feedback_needed release_note:enhancement labels Nov 18, 2014
@stormpython
Copy link
Contributor

The issue here is that in the vislib, x axis values that are numbers are being sorted by their actual x axis value. Since I wrote the code for this, I will apply a fix. Not sure why I added sorting for numbers by their x axis value. I will need to test different scenarios before applying the fix.

We can perhaps open another ticket to allow the user to choose an option to sort bars by, but this is a bug since all bars on terms aggregations should be ordered by count as the default.

@stormpython stormpython self-assigned this Nov 18, 2014
stormpython added a commit to stormpython/kibana that referenced this issue Nov 18, 2014
@stormpython
Closes elastic#1903. Removing sortBy of index positions from ordered_…
f1b15fb 
…x_keys module.
@stormpython stormpython mentioned this issue Nov 18, 2014
Merged
@jimmyjones2 jimmyjones2 mentioned this issue Nov 19, 2014
Closed
@stormpython stormpython mentioned this issue Nov 21, 2014
Closed
@stormpython stormpython added this to the 4.0.0-BETA3 milestone Nov 22, 2014
stormpython added a commit to stormpython/kibana that referenced this issue Nov 24, 2014
@stormpython
Merge branch 'master' into fix/elastic#1903
ed42e73
stormpython added a commit to stormpython/kibana that referenced this issue Nov 25, 2014
@stormpython
Closes elastic#1903. Results are returned in the order that elasticse…
e54e641 
…arch sends them. That is, in descending order with the biggest values first. Changed the index which is recorded from the highest to the lowest. So the lowest index position is taken for an x value instead of the highest. In addition, we were not actually sorting by indexed position before, so this fixes that bug.
stormpython added a commit to stormpython/kibana that referenced this issue Nov 25, 2014
@stormpython
Merge branch 'master' into fix/elastic#1903
7cdc6af
stormpython added a commit to stormpython/kibana that referenced this issue Dec 1, 2014
@stormpython
Merge branch 'master' into fix/elastic#1903
9267cd8
stormpython added a commit that referenced this issue Dec 1, 2014
@stormpython
Merge pull request #1968 from stormpython/fix/#1903
0f133a7 
Allow ordering of bars by count on term aggregation when x axis values are numbers
@jthomassie jthomassie mentioned this issue Dec 4, 2014
Merged
@enterstudio enterstudio mentioned this issue Dec 4, 2022
Open
@xhad xhad mentioned this issue Dec 4, 2022
Open
@82ndAirborneDiv 82ndAirborneDiv mentioned this issue Dec 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stormpython stormpython

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation PR sent
Projects
None yet
Milestone
4.0.0-BETA3
3 participants
@rashidkpc @jimmyjones2 @stormpython