Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overflow-scrolling): remove old patch now unnecessary, closes #332 #339

Merged
merged 1 commit into from
Feb 9, 2019

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Feb 8, 2019

Issue reference #332
This old patch was to fix a Mac only (Chrome on Mac) problem, however this patch is no longer necessary since the Chrome problem got fixed 2 years ago ("Work around http://crbug.com/312427." - Inertial scrolling bug in WebKit/Blink in Mac OS X breaks virtual list implementations). This in terms fixes issue #332

@ghiscoding
Copy link
Collaborator Author

@6pac
I'll let you decide if you this PR merged now or after the new NPM version. On that side, I am ready for the new version to be released, I made all my tests and did fix 2 small issues. If you could release the NPM version in this weekend, that would be awesome. Thanks

@6pac 6pac merged commit f44a398 into master Feb 9, 2019
@ghiscoding ghiscoding deleted the bugfix/overflow-scrolling branch March 7, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants