Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add nonce grid option set the nonce value for CSP header #902

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: add nonce grid option set the nonce value for CSP header #902

merged 2 commits into from
Nov 2, 2023

Conversation

JesperJakobsenCIM
Copy link
Contributor

No description provided.

@ghiscoding ghiscoding changed the title Made the user set the nonce value feat: add nonce grid option set the nonce value for CSP header Nov 2, 2023
ghiscoding
ghiscoding reviewed Nov 2, 2023
View reviewed changes
src/slick.grid.ts Outdated Show resolved Hide resolved
@ghiscoding
Copy link
Collaborator

ghiscoding commented Nov 2, 2023 •
edited
Loading

@JesperJakobsenCIM this looks good, I just have 1 requested change. Also please note that I changed the title of your PR because we follow Conventional Commits in order to automatically update our changelog.md files and for the GitHub release as well, in your use case I chose fix: ... because I don't want to create a minor version but I guess typically a feat: would be better but I want to release my other bug fix probably tonight and I don't want a minor version

@ghiscoding ghiscoding changed the title feat: add nonce grid option set the nonce value for CSP header fix: add nonce grid option set the nonce value for CSP header Nov 2, 2023
ghiscoding added a commit that referenced this pull request Nov 2, 2023
@ghiscoding
fix: add nonce grid option set the nonce value for CSP header
b1270d2 
- backported from PR #902
@ghiscoding ghiscoding merged commit cb39c7a into 6pac:feat/drop-inner-html Nov 2, 2023
@ghiscoding
Copy link
Collaborator

good to merge after the change I made, thanks for the contribution :)

@ghiscoding ghiscoding mentioned this pull request Nov 2, 2023
Merged
ghiscoding added a commit that referenced this pull request Nov 2, 2023
@ghiscoding
fix: add nonce grid option set the nonce value for CSP header (#904)
21a220e 
- backported from PR #902
@ghiscoding
Copy link
Collaborator

It's now available in v5.4.2 thanks again :)

@ghiscoding
Copy link
Collaborator

oh actually it's not available, I just noticed that you create the PR against the wrong branch 6pac:feat/drop-inner-html, so it's not released yet, I will create another PR to merge this to master branch as it should be. It will have to wait for a future release, I'm done with all my fixes so it's probably going to wait for a few more weeks.

ghiscoding pushed a commit that referenced this pull request Nov 2, 2023
@JesperJakobsenCIM @ghiscoding-SE
fix: add nonce grid option set the nonce value for CSP header (#902)
fc0af7a 
* Made the user set the nonce value
@ghiscoding ghiscoding mentioned this pull request Nov 2, 2023
Merged
ghiscoding added a commit that referenced this pull request Nov 2, 2023
@ghiscoding @JesperJakobsenCIM
fix: add nonce grid option set the nonce value for CSP header (#902) (
fb0e4f5 
#905)

* fix: add `nonce` grid option set the nonce value for CSP header (#902)

* Made the user set the nonce value

* chore: add back previous CSP header

---------

Co-authored-by: Jesper Jakobsen <[email protected]>
@ghiscoding ghiscoding mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghiscoding ghiscoding ghiscoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesperJakobsenCIM @ghiscoding