Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sub-menu event listeners leaking when closing sub-menus #888

Merged
merged 1 commit into from
Oct 27, 2023
Merged

fix: sub-menu event listeners leaking when closing sub-menus #888

merged 1 commit into from
Oct 27, 2023

Conversation

ghiscoding
Copy link
Collaborator

  • when a sub-menu is closed, we remove it from the DOM but we also need to remove any click event listeners attached to all list items

@ghiscoding-SE
fix: sub-menu event listeners leaking when closing sub-menus
0f4e2ff 
- when a sub-menu is closed, we remove it from the DOM but we also need to remove any click event listeners attached to all list items
@ghiscoding ghiscoding merged commit 338ea2a into master Oct 27, 2023
@ghiscoding ghiscoding deleted the bugfix/sub-menus-event-leaking branch October 27, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @ghiscoding-SE