Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CellSelectionModel calculate page row count only once #858

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: CellSelectionModel calculate page row count only once #858

merged 2 commits into from
Oct 5, 2023

Conversation

ghiscoding
Copy link
Collaborator

  • for better perf, we shouldn't have to recalculate page row count on every key change (i.e. clicking PageDown multiple times will remain the same row count displayed in the page), we can cache the row count and just reuse it

@ghiscoding
fix: CellSelectionModel calculate page row count only once
7ecd10e 
- for better perf, we shouldn't have to recalculate page row count on every key change (i.e. clicking PageDown multiple times will remain the same row count displayed in the page), we can cache the row count and just reuse it
@ghiscoding
chore: cleanup code and add missing semicolons
4c8c75e
@ghiscoding ghiscoding merged commit 65c2382 into master Oct 5, 2023
@ghiscoding ghiscoding deleted the chore/cell-selection-page-row-count-cache branch October 5, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding