Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated DataView methods #833

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Conversation

ghiscoding
Copy link
Collaborator

  • setAggregators and groupBy were both replaced by setGrouping many years ago, so no need to keep these old functions anymore

- `setAggregators` and `groupBy` were both replaced by `setGrouping` many years ago, so no need to keep these old functions anymore
@ghiscoding ghiscoding merged commit 0f3ba49 into next Aug 10, 2023
2 checks passed
@ghiscoding ghiscoding deleted the chore/dataview-deprecation branch August 10, 2023 20:07
ghiscoding added a commit that referenced this pull request Sep 19, 2023
* feat!: major folder restructuring with esbuild to support `iife`, `cjs` and `esm` and soon TypeScript (#804)

* feat: migrate all Controls to TypeScript (#808)

* feat: migrate all Menu/Buttons Plugins to TypeScript (#811)

* feat: migrate all Decorator & Selection Plugins to TypeScript (#812)

* feat: migrate CheckboxSelector & State Plugins to TypeScript (#813)

* feat: migrate Draggable Grouping Plugins to TypeScript (#814)

* feat: migrate Resizer Plugin to TypeScript (#815)

* feat: migrate RowMoveManager Plugins to TypeScript (#817)

* feat: migrate RowDetail Plugin to TypeScript (#822)

* feat: migrate RemoteModel Plugins to TypeScript (#823)

* feat: remove deprecated DataView methods (#833)

* feat: remove deprecated DataView methods
- `setAggregators` and `groupBy` were both replaced by `setGrouping` many years ago, so no need to keep these old functions anymore

* feat: add new trading platform high frequency update grid (#835)

* feat: add new trading platform high frequency update grid

* fix: copying multiple times only kept last undo CellExternalCopyManager
- fix an issue where copying and pasting to multiple area only kept the last undo and reapplied it over and over and the cause was because the clipCommand was global to the class so it only kept the last undo, the fix is to make sure the clipCommand variable is local to the execution handler instead

---------

Co-authored-by: Nikhil Giddaluru <[email protected]>
Co-authored-by: Ben McIntyre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant