Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): example with 3 plugins not sorting correctly #788

Merged
merged 1 commit into from
Jun 17, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jun 17, 2023

  • example with 3 plugins was sorting with a column offset, the reason was because the RowMove plugin was created after SlickGrid and for that reason RowMove wasn't part of the columns passed to SlickGrid
  • in short all plugins must change the columns array before passing it to the SlickGrid creation

brave_28WEVqcU72

- example with 3 plugins was sorting with a column offset, the reason was because the RowMove plugin was created after SlickGrid and for that reason RowMove wasn't part of the columns passed to SlickGrid
- in short all plugins must change the `columns` array before passing it to the SlickGrid creation
@ghiscoding ghiscoding requested a review from 6pac June 17, 2023 04:35
@6pac 6pac merged commit e749aa9 into master Jun 17, 2023
@6pac 6pac deleted the bugfix/3plugins-examples-sorting branch June 17, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants