Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide another styling theme #779

Merged
merged 6 commits into from
May 23, 2023
Merged

feat: provide another styling theme #779

merged 6 commits into from
May 23, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented May 19, 2023

  • the theme was copied from vue-slimgrid project and adjusted a bit, not perfect but provides a bit more modern styling theme
  • I just copied 3 examples and renamed them so that we can link them in the Wiki list of Examples

below are some print screens showing the differences (left/right)

image

image

image

@ghiscoding ghiscoding requested a review from 6pac May 22, 2023 04:23
@6pac
Copy link
Owner

6pac commented May 22, 2023

Great. The original theme is looking a bit dated these days.

I noticed when I was editing the docs that the original grid supported jQueryUI themes. Not that I have a clue how to use jQueryUI themes! But wondering if there's a more modern theming standard we could piggyback off.

@ghiscoding
Copy link
Collaborator Author

I have my own themes and I won't use this theme but it's still more modern than what's currently in place. I don't want to put more time on this, it's either we use it or we forget it, my intention was just to show an alternative so that users know it's possible to change by themselves

@6pac 6pac merged commit bc96ddf into master May 23, 2023
@6pac 6pac deleted the feat/slim-style branch May 23, 2023 06:31
ghiscoding added a commit that referenced this pull request May 28, 2023
ghiscoding added a commit that referenced this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants