Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cell selection in Firefox not working, fixes #714 #715

Merged
merged 4 commits into from
Dec 28, 2022
Merged

fix: cell selection in Firefox not working, fixes #714 #715

merged 4 commits into from
Dec 28, 2022

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding requested a review from 6pac December 24, 2022 00:45
@ghiscoding
Copy link
Collaborator Author

@6pac you can check this PR too

@6pac
Copy link
Owner

6pac commented Dec 28, 2022

looks good

@6pac 6pac merged commit 3583ffc into master Dec 28, 2022
@ghiscoding
Copy link
Collaborator Author

ghiscoding commented Dec 29, 2022 •
edited
Loading

@6pac probably good to do a patch release, the other PRs will take time to review and won't be patches only.

There's also a few extra files that are being published as well, any chance you can clean them on your side? They seem to only exist on your end, not on the GitHub repo. You can see them on this unpkg link

image

@ghiscoding ghiscoding deleted the bugfix/firefox-cell-selection branch December 29, 2022 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6pac 6pac Awaiting requested review from 6pac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @6pac