WIP - fix(dataView): add option to apply row selection to all pages #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed the need for dedupe by using ._used flag
attempt at new recursive search
refactored funcs to allow nested array of objects or object of objects
…y`ed events - in this case, userData is actually the triggering `jQuery.Event`
updating master
`state` will now only `scrollRowIntoView` if user wishes to
|
thanks for the detailed explanation. will check it out. |
ghiscoding
added a commit
that referenced
this pull request
Dec 27, 2022
- supersede #689, most Grid & DataView changes were kept with some small changes & fixes, also added more Cypress E2E tests - when having pages and `syncGridSelection` is called with `preserveHiddenOnSelectionChange`, clicking on Select All checkbox: - it will apply row selections on all rows - if nothing is selected and we filter data, then we click on Select All, it will apply row selections only to the item being filtered and if we remove filters then the Select All is not expect to be selected
|
rewrote the changes into another PR #716 since this one contains other unrelated commits and is not based on latest branch, so the new PR should fix that. There are also some small fixes applied on top of code from this PR. @arashdalir can you please review PR #716, we won't merge it until you can confirm it |
6pac
pushed a commit
that referenced
this pull request
Feb 3, 2023
* feat(dataView): add option to apply row selection to all pages - supersede #689, most Grid & DataView changes were kept with some small changes & fixes, also added more Cypress E2E tests - when having pages and `syncGridSelection` is called with `preserveHiddenOnSelectionChange`, clicking on Select All checkbox: - it will apply row selections on all rows - if nothing is selected and we filter data, then we click on Select All, it will apply row selections only to the item being filtered and if we remove filters then the Select All is not expect to be selected * chore: rollback slick.grid.js changes - the changes to slick.grid.js should be applied in a different PR and there's also one opened for this * chore: add selected rows ids to onSelectedRowIdsChanged * chore: add option to apply grid row selection with setSelectedIds * chore: rename option to better represent applying row selection to grid * chore: change setSelectedIds option defaults * chore: show setSelectedIds options * chore: add demo & tests for row selection on multiple pages * chore: use setSelectedIds new option object instead of boolean arg * chore: fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is PR made ONLY to allow comparing my working solution for #545 and is not to be merged. it contains:
checkbox-header-rowexample to showcase the new functionalitiescheckboxplugindataview- stores a list of selected IDs, and in case dataset is filtered or paged, the selected ID list is managed properly and is passed to dataviewdataviewonSelectedRowIdsChangedis added to allow other parts of the system to inform dataview of changes to selected rowspreserveHiddenandpreserveHiddenOnSelectionChangeare now considered more accurately when selected rows are changed. if the latter parameter is set, the selected hidden rows (i.e. filtered rows) will still be selected if the selection changes (which is the goal of that parameter).getAllSelectedFilteredIds,getAllSelectedFilteredItems,setSelectedIdsgetAllSelectedIdsthis PR also contains other useful things:
gridmenugriditself:multisortby considering all available columns and not just visible columnsthis PR also contains some irrelevant things:
cypress/integration/example-checkbox-header-row.spec.js- irrelevantexample-tree-data- no idea why I have this :/ irrelevanttreedataplugin - no idea why I have merged it into my code! :/ irrelevant