Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: we should remove all event listeners when calling destroy #556

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix: we should remove all event listeners when calling destroy #556

merged 1 commit into from
Nov 26, 2020

Conversation

ghiscoding
Copy link
Collaborator

  • this is to avoid having events leaking in memory from possible detached elements

@ghiscoding
fix: we should remove all event listeners when calling destroy
8fbd5d6 
- this is to avoid having events leaking in memory from possible detached elements
@ghiscoding ghiscoding requested a review from 6pac November 26, 2020 19:10
@6pac 6pac merged commit 708b070 into master Nov 26, 2020
@ghiscoding ghiscoding deleted the bugfix/dispose-events-on-destroy branch November 28, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6pac 6pac Awaiting requested review from 6pac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @6pac